Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload an arbitrary number of files #578

Closed
wants to merge 14 commits into from
Closed

Upload an arbitrary number of files #578

wants to merge 14 commits into from

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Jun 30, 2020 •
edited by schloerke
Loading

Fixes #575
Fixes #582

Issue #575, should probably have been there in #550.

Swagger UI does not support it, Rapidoc does, it will work from a CURL command

PR task list:

  • [NA] Update NEWS
  • Add tests
  • [NA] Update documentation with devtools::document()

schloerke
schloerke reviewed Jun 30, 2020
View reviewed changes
R/parse-body.R Outdated Show resolved Hide resolved
@meztez
Copy link
Collaborator Author

meztez commented Jul 1, 2020 •
edited by schloerke
Loading

After more thinking:

Removed the notion of arraySupport in api types, all types support array.

File parameters will always return in the form list(filename1 = rawBytes, filename2 = rawBytes, ...) instead of a raw vector with attribute filename = filename1.

Fixes #582

meztez
meztez commented Jul 3, 2020
View reviewed changes
R/parse-body.R Outdated Show resolved Hide resolved
@meztez
Copy link
Collaborator Author

meztez commented Jul 3, 2020

ready for review

@schloerke schloerke requested a review from cpsievert July 9, 2020 14:52
schloerke
schloerke reviewed Jul 24, 2020
View reviewed changes
R/parse-body.R Outdated Show resolved Hide resolved
This was referenced Aug 7, 2020
Merged
Merged
Merged
Merged
@schloerke schloerke added the Fixed in PR A PR has implemented a fix for this Issue label Aug 12, 2020
@meztez meztez closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke left review comments

@cpsievert cpsievert Awaiting requested review from cpsievert

Assignees
No one assigned
Labels
Fixed in PR A PR has implemented a fix for this Issue
Projects
None yet
Milestone
No milestone
2 participants
@meztez @schloerke