Parsing query string arrays #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change parseQS so that if elements of the parsed query string are the same, they are combined into a vector.
|
|
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 88.08% 88.14% +0.06%
==========================================
Files 23 23
Lines 1116 1122 +6
==========================================
+ Hits 983 989 +6
Misses 133 133
Continue to review full report at Codecov.
|
|
Awesome! Thanks so much for contributing, and sorry for the slow response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a query string has multiple of the same element. For example ‘keyword=hello&keyword=goodbye’, these form an array and should probably be parsed in R as a vector e.g. keyword = c(‘hello’, ‘goodbye’).
Currently having multiple elements of the same name in a query string just raises an error. The pull request aims to fix this and has added a test for it.