cookie expires and max-age arguments format #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 88.18% 88.18%
=======================================
Files 24 24
Lines 1193 1193
=======================================
Hits 1052 1052
Misses 141 141
Continue to review full report at Codecov.
|
|
🤦♂️ How'd I miss this? Thanks for contributing. Change looks great. Closes #216 |
trestletech
added a commit
that referenced
this pull request
Dec 4, 2017
I needed to merge the 0.4.4 changes before merging this to have a stable tag. Will un-revert momentarily. This reverts commit 3313bed.
trestletech
pushed a commit
that referenced
this pull request
Dec 4, 2017
* cookie format * cookie format on test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I corrected the cookie format to make its expires and max-age arguments work.
Regards