Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Date header as httpuv does this automatically now #380

Merged
merged 5 commits into from
Feb 7, 2019
Merged

Remove the Date header as httpuv does this automatically now #380

merged 5 commits into from
Feb 7, 2019

Conversation

schloerke
Copy link
Collaborator

Fixes #378
Fixes #319

The Date header is being published by httpuv automatically. No need to do this manually.

rstudio/httpuv@8bdeea2

@schloerke schloerke requested a review from wch February 5, 2019 16:20
wch
wch requested changes Feb 5, 2019
View reviewed changes
Copy link
Collaborator

@wch wch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also bump the httpuv version requirement to 1.4.5.9002. Also, I think the tests from #319 need to be removed.

Also, an entry in NEWS?

@codecov-io
Copy link

codecov-io commented Feb 5, 2019 •
edited
Loading

Codecov Report

Merging #380 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage    87.9%   87.77%   -0.14%     
==========================================
  Files          27       27              
  Lines        1207     1194      -13     
==========================================
- Hits         1061     1048      -13     
  Misses        146      146
Impacted Files Coverage Δ
R/response.R 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f29c9b...2593b11. Read the comment docs.

@schloerke schloerke requested a review from wch February 5, 2019 17:36
@schloerke
Merge branch 'master' into httpuv_date
2593b11 
* master:
  use rtools within appveyor (#381)
@schloerke schloerke added the QA Submitted for QA label Feb 7, 2019
@schloerke schloerke merged commit 331a9ea into master Feb 7, 2019
@schloerke schloerke deleted the httpuv_date branch February 7, 2019 21:03
schloerke added a commit that referenced this pull request Feb 7, 2019
@schloerke
Merge branch 'master' into promises
7041b0a 
* master:
  Remove the Date header as httpuv does this automatically now (#380)
schloerke added a commit that referenced this pull request Feb 11, 2019
@schloerke
Merge branch 'master' into httpuv_url_decode
b8b4bcc 
* master:
  hard code swagger-ui version as plumber is tied to that major ui version (#374)
  Remove the Date header as httpuv does this automatically now (#380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
QA Submitted for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schloerke @codecov-io @wch