Use bytes charset for multipart input #504
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75.
My fork of @sellorm's demo at https://github.com/krlmlr/plumber-uploader/tree/f-multipart contains an example of reliably processing multipart data using
mime::parse_multipart()
. This PR adds special treatment for multipart input.Pull Request
Before you submit a pull request, please do the following:
Add an entry to NEWS concisely describing what you changed.
Add unit tests in the tests/testthat directory.
Run Build->Check Package in the RStudio IDE, or
devtools::check()
, to make sure your change did not add any messages, warnings, or errors.Doing these things will make it easier for the plumber development team to evaluate your pull request. Even so, we may still decide to modify your code or even not merge it at all. Factors that may prevent us from merging the pull request include:
We will try to be responsive and provide feedback in case we decide not to merge your pull request.
Minimal reproducible example
Finally, please include a minimal reprex. The goal of a reprex is to make it as easy as possible for me to recreate your problem so that I can fix it. If you've never heard of a reprex before, start by reading https://github.com/jennybc/reprex#what-is-a-reprex, and follow the advice further down the page. Do NOT include session info unless it's explicitly asked for, or you've used
reprex::reprex(..., si = TRUE)
to hide it away.Delete these instructions once you have read them.
Brief description of the original problem and the approach behind your solution.
# insert reprex here
PR task list:
devtools::document()