Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yaml support #556

Merged
merged 8 commits into from
Jun 23, 2020
Merged

Add yaml support #556

merged 8 commits into from
Jun 23, 2020

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Jun 22, 2020

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

Bruno Tremblay added 2 commits June 22, 2020 00:59
schloerke
schloerke reviewed Jun 22, 2020
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@schloerke schloerke requested review from schloerke and cpsievert June 22, 2020 17:58
schloerke
schloerke approved these changes Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With suggestion

@schloerke schloerke added this to the v0.5.0 - Next CRAN release milestone Jun 22, 2020
meztez and others added 4 commits June 22, 2020 14:08
@meztez @schloerke
Update NEWS.md
a8cdc20 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@meztez @schloerke
Update tests/testthat/test-serializer-yaml.R
929a883 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@meztez @schloerke
Update tests/testthat/test-serializer-yaml.R
1d6bcd5 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@meztez @schloerke
Update tests/testthat/test-postbody.R
531c752 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@schloerke schloerke merged commit 0de28bc into rstudio:master Jun 23, 2020
@meztez meztez mentioned this pull request Jun 24, 2020
Closed
@meztez meztez deleted the add_yaml_support branch June 24, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@meztez @schloerke @cpsievert