Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Swagger to OpenAPI Specification #560

Merged
merged 6 commits into from
Jun 23, 2020
Merged

Rename Swagger to OpenAPI Specification #560

merged 6 commits into from
Jun 23, 2020

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Jun 23, 2020

… OpenAPI

  • NA Update NEWS, no user facing changes I think
  • NA Add tests
  • Update documentation with devtools::document()

Bruno Tremblay added 3 commits June 22, 2020 20:26
Rename and reorganize files, removing most of swagger api in favor of…
1ae15c4 
… OpenAPI
typos
edd1daf
merge master
961e3f0 
Merge remote-tracking branch 'upstream/master' into rename_reorganize

# Conflicts:
#	man/plumber.Rd
@schloerke
Copy link
Collaborator

schloerke commented Jun 23, 2020 •
edited
Loading

Small comment: Can we move the content of ./R/parsers-body.R underneath the content of ./R/parse-body.R? This should all be grouped anyways. (Then delete ./R/parsers-body.R)

@meztez
Copy link
Collaborator Author

meztez commented Jun 23, 2020

Small comment: Can we move the content of ./R/parsers-body.R underneath the content of ./R/parse-body.R? This should all be grouped anyways. (Then delete ./R/parsers-body.R)

Should we do the same for serializers? There is bunch of them under different files.

@schloerke
Copy link
Collaborator

schloerke commented Jun 23, 2020 •
edited
Loading

@meztez Let's leave them for now. I'm going to create as serializer_with_headers(...) function as a base case for serializer_content_type(). This will allow for #455 to have a leg to stand on and allow all other serializers to leverage the benefits / remove the boilerplate.

I'll remove them then.

(PR coming in a few days.)

Bruno Tremblay added 2 commits June 22, 2020 21:17
@schloerke schloerke requested a review from cpsievert June 23, 2020 17:10
cpsievert
cpsievert reviewed Jun 23, 2020
View reviewed changes
R/plumber.R Show resolved Hide resolved
cpsievert
cpsievert reviewed Jun 23, 2020
View reviewed changes
R/plumber.R Show resolved Hide resolved
@cpsievert cpsievert self-requested a review June 23, 2020 19:42
@schloerke schloerke mentioned this pull request Jun 23, 2020
Closed
@schloerke schloerke changed the title Rename and reorganize files, removing most of swagger api in favor of… Rename Swagger to OpenAPI Specification Jun 23, 2020
@schloerke schloerke merged commit 20f79f0 into rstudio:master Jun 23, 2020
@meztez meztez deleted the rename_reorganize branch June 24, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meztez @schloerke @cpsievert