Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with lifecycle package #651

Merged
merged 15 commits into from
Aug 18, 2020
Merged

Integrate with lifecycle package #651

merged 15 commits into from
Aug 18, 2020

Conversation

schloerke
Copy link
Collaborator

Remaining questions:

  • Should plumber be transformed to Plumber?
    • Should hookable be transformed to Hookable?
    • If so, should plumber still exist?
  • Should plumber's historical R6 methods be converted to snake_case?
    • If so, should PlumberEndpoint's R6 methods be converted to snake_case?

  • plumber$run() args now use lifecycle package and deprecation notice
  • randomCookieKey() -> random_cookie_key()
  • sessionCookie() -> session_cookie()
  • getCharacterSet() -> get_character_set()

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Aug 17, 2020
@schloerke schloerke requested a review from cpsievert August 17, 2020 19:27
@schloerke schloerke changed the title Deprecate all the things Integrate with lifecycle package Aug 17, 2020
R/plumb-block.R Outdated Show resolved Hide resolved
R/plumber.R Outdated Show resolved Hide resolved
R/deprecated.R Outdated Show resolved Hide resolved
@schloerke schloerke mentioned this pull request Aug 18, 2020
@schloerke schloerke merged commit 48fa2ca into master Aug 18, 2020
@schloerke schloerke deleted the deprecate_all_the_things branch August 18, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants