-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use promise domain to manage graphics devices #669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use loops to get direct failure location vs a "it happened in the lapply" error
…he expected order
…ion, do not cause an error
cpsievert
approved these changes
Sep 11, 2020
* master: Add peer dependency which npm does not install by default (#670)
The windows error above is a false positive. |
schloerke
added a commit
that referenced
this pull request
Sep 11, 2020
* master: Use promise domain to manage graphics devices (#669)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visit
/promise_plot1
and then quickly visit/promise_plot2
before/promise_plot1
has resolved. Before the PR, this would cause an error and/promise_plot2
would display the plot for/promise_plot1
. After this PR, there is no error and the images as expected.PR task list:
devtools::document()