Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guess OpenAPI response type from serializer #684

Merged
merged 8 commits into from
Dec 29, 2020
Merged

Guess OpenAPI response type from serializer #684

merged 8 commits into from
Dec 29, 2020

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Oct 2, 2020 •
edited by schloerke
Loading

In response to #420

reprex

a <- pr()
pr_get(a, "/json", function() {"OK"}, serializer = serializer_json)
pr_get(a, "/csv", function() {"OK"}, serializer = serializer_csv())
spec <- a$getApiSpec()

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@meztez meztez force-pushed the openapi_response_ctype branch from 685ebdb to 392a41e Compare October 2, 2020 01:22
schloerke
schloerke reviewed Dec 29, 2020
View reviewed changes
R/openapi-spec.R Outdated Show resolved Hide resolved
schloerke
schloerke reviewed Dec 29, 2020
View reviewed changes
R/openapi-spec.R Outdated Show resolved Hide resolved
schloerke
schloerke reviewed Dec 29, 2020
View reviewed changes
R/openapi-spec.R Outdated Show resolved Hide resolved
schloerke
schloerke reviewed Dec 29, 2020
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@schloerke
Copy link
Collaborator

Fix failure in master branch. Merging

@schloerke schloerke merged commit 49f5fcd into rstudio:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meztez @schloerke