Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always redirect /__swagger_/ to /__docs__/ #694

Closed
wants to merge 1 commit into from
Closed

Always redirect /__swagger_/ to /__docs__/ #694

wants to merge 1 commit into from

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Oct 9, 2020

Fix #693 (remove is_swagger condition)

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@schloerke schloerke mentioned this pull request Oct 9, 2020
Closed
schloerke
schloerke reviewed Oct 9, 2020
View reviewed changes
R/ui.R Outdated Show resolved Hide resolved
schloerke
schloerke reviewed Oct 9, 2020
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@cpsievert cpsievert self-requested a review October 15, 2020 20:05
@cpsievert
Copy link
Contributor

Let's expose an option to avoid adding the redirect if people really want that

@cpsievert
Copy link
Contributor

Also add a check for an existing route at the __swagger__ redirect locations

cpsievert
cpsievert approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with pending suggestions

@meztez meztez mentioned this pull request Oct 16, 2020
Closed
@meztez
Copy link
Collaborator Author

meztez commented Oct 16, 2020

Also add a check for an existing route at the __swagger__ redirect locations

I think only having the options to disable redirects should be ok.
I you want to use those route, use the options to disable redirects?

@meztez
Copy link
Collaborator Author

meztez commented Oct 17, 2020 •
edited
Loading

@meztez Split fix to #701 to a separate PR #702

@meztez meztez force-pushed the redirect_swagger_always branch from e7c2e54 to b5c0f1e Compare October 17, 2020 15:15
@schloerke
Copy link
Collaborator

Thank you @meztez for splitting the PR!

@schloerke schloerke mentioned this pull request Oct 19, 2020
Merged
2 tasks
@schloerke
Copy link
Collaborator

Closing in favor of #704

@schloerke schloerke closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always redirect __swagger__ to __docs__
3 participants
@meztez @cpsievert @schloerke