Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote the version number in Dockerfile #751

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Quote the version number in Dockerfile #751

merged 2 commits into from
Jan 5, 2021

Conversation

schloerke
Copy link
Collaborator

Fixes #750

@schloerke schloerke added this to the v1.1.0 milestone Jan 4, 2021
@schloerke
Copy link
Collaborator Author

schloerke commented Jan 4, 2021 •
edited
Loading

@kassemsandarusi (or anyone) Can you please try again. I have verified that rstudio/plumber:latest, :v1.0.0, :next and v0.4.6 work locally on my machine

(Please comment so that I get a notification. Will on confirmation. Thank you!)

@schloerke
Copy link
Collaborator Author

Going to merge as I can not run the master version, but I can run this PR's version.

@schloerke schloerke changed the title Quote the version number Quote the version number in Dockerfile Jan 5, 2021
@schloerke schloerke merged commit 1d11c9e into master Jan 5, 2021
@schloerke schloerke deleted the docker-patch-1 branch January 5, 2021 15:16
schloerke added a commit that referenced this pull request Jan 5, 2021
@schloerke
Merge branch 'master' into mnt_updates
04f1dbb 
* master:
  Quote the version number in Dockerfile (#751)
  Do not use `plan(multiprocess)`. Instead, use `plan(multisession)` (#747)
  Default res headers to named list instead of list (#745)
  Add stage debugging section in Tips&Tricks (#741)
  Switch `Plumber$print()` wording to use magrittr api (#742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

v1.0.0 Plumber Docker Entrypoint
1 participant
@schloerke