Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint description field to API spec #805

Merged
merged 10 commits into from
Jun 3, 2022
Merged

Conversation

wkmor1
Copy link
Contributor

@wkmor1 wkmor1 commented May 18, 2021

With this change the first line of endpoint block comments are interpreted as OpenAPI 'summary' field and subsequent comment lines interpreted as the 'description' field. Technically this is a breaking change for anyone who is intentionally breaking 'summary' field comments over more than one line. On the other hand maybe more intuitive as splitting line 1 vs line 2-N is more like the behavior of Roxygen comments -> DESCRIPTION file fields, title and description.

R/plumb-block.R Outdated Show resolved Hide resolved
R/plumb-block.R Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
wkmor1 and others added 6 commits January 19, 2022 09:31
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@schloerke schloerke requested a review from wch June 2, 2022 19:09
tests/testthat/test-parse-block.R Show resolved Hide resolved
@schloerke schloerke closed this Jun 2, 2022
@schloerke schloerke reopened this Jun 2, 2022
@schloerke
Copy link
Collaborator

Thank you! (Sorry clicked the wrong button there)

@schloerke schloerke merged commit d932ac8 into rstudio:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants