-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update feather serializer; Add parquet serializer #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can be interesting in terms of performance for mid-sized tables |
schloerke
reviewed
Jan 18, 2022
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@schloerke all ready now ! |
hi @schloerke ! |
schloerke
approved these changes
Mar 24, 2022
schloerke
changed the title
update feather serializers + add parquet serializer
Update feather serializer; Add parquet serializer
Mar 24, 2022
schloerke
added a commit
that referenced
this pull request
Jun 2, 2022
* main: Fix Content-Length header on HTTP responses which forbid it (#760) Generate docs and fix existing tests (#860) decode static URI before serving (#754) Update feather serializer; Add parquet serializer (#849) remove author in pkgdown; have website build again Fix plumber website. Use tidytemplate (#851) Runtime Vignette typo (#848) GHA v2 (#842) master -> main (#839) Create GeoJSON serializer and parser (#830) Add details about named functions as router modifiers (#824) Parser params should be in a `list()` (#827) Test on ubuntu 18/20 and use relative R versions (#828) Shared secret rejections are not errors (#809) Fix tag endpoint block annotation spelling to `@tag` (#800) Add ORCID info (#794) Add blog post link to website (#792) Use serializer Content-Type header for PlumberEndpoint API spec (#789) Use dev version (#790) v1.1.0 (#752)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Before you submit a pull request, please do the following:
Add an entry to NEWS concisely describing what you changed. OK
Add unit tests in the tests/testthat directory. OK
Run Build->Check Package in the RStudio IDE, or
devtools::check()
, to make sure your change did not add any messages, warnings, or errors. OKThe relevant tests were added to these files:
In addition, I separated the PR in different pushes (i.e. 1 for content + 1 for NEWS + 1 for tests)
Minimal reproducible example
I created a mini API to test both from browser and in R with download,file
MIni API
I run this mini API from RStudio with the command
plumber::plumb("plumber.R")$run(port = 1234)
Then I run these reproducible tests in a new RStudio window
All good!
PR task list:
devtools::document()
In addition, I added myself as ctb, after adding #520, #398 and #360.