Improve object cleanup #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make message more informative * Switch from `warning()` to `cat()` so can test it (condition handling is disabled during `gc()`) * Release object to avoid additional message on pool close Fixes #95
hadley
commented
Jan 6, 2023
#Conflicts: # NEWS.md # R/scheduler.R
|
Now includes thorough pass over all error messages and conversion of all warnings to |
|
Joe say: dangerous to do anything in the finalizer because it's so unpredictable. So back that out. |
|
Need to convert all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warning()tocat()so can test it (condition handling is disabled duringgc())