avoid false positive for packages installed without known source (#1689)

NEWS.md

@@ -1,5 +1,8 @@
 # renv (development version)
 
+* Fixed an issue where `renv` could warn the project appeared to be out-of-sync
+  when using packages installed without an explicit source recorded. (#1683)
+
 * `renv::install()` gains the `exclude` argument, which can be useful when
   installing a subset of project dependencies.
 

R/autoload.R

@@ -41,8 +41,7 @@ renv_autoload_impl <- function() {
     return(FALSE)
 
   # bail if load is already being called
-  loading <- getOption("renv.load.running")
-  if (identical(loading, TRUE))
+  if (the$load_running)
     return(FALSE)
 
   # avoid recursion

R/load.R

@@ -1,4 +1,7 @@
 
+# are we currently running 'load()'?
+the$load_running <- FALSE
+
 #' Load a project
 #'
 #' @description
@@ -69,7 +72,7 @@ load <- function(project = NULL, quiet = FALSE) {
   renv_project_lock(project = project)
 
   # indicate that we're now loading the project
-  renv_scope_options(renv.load.running = TRUE)
+  renv_scope_binding(the, "load_running", TRUE)
 
   # if load is being called via the autoloader,
   # then ensure RENV_PROJECT is unset

R/lockfile-diff.R

@@ -61,6 +61,20 @@ renv_lockfile_diff_record <- function(before, after) {
   if (!is.null(type))
     return(type)
 
+  # if we're running this as part of 'load()', and we're comparing
+  # packages with unknown sources, then just ignore those -- this
+  # is because we disable the 'guess repository' hack on startup,
+  # to avoid a potentially expensive query of package repositories
+  #
+  # https://github.com/rstudio/renv/issues/1683
+  if (the$load_running) {
+    unknown <-
+      identical(before$Source, "unknown") ||
+      identical(after$Source,  "unknown")
+    if (unknown)
+      return(NULL)
+  }
+
   # check for a crossgrade -- where the package version is the same,
   # but details about the package's remotes have changed
   if (!setequal(renv_record_names(before), renv_record_names(after)))