Skip to content

Commit

Permalink
suggest cleanrmd for e499bf7
Browse files Browse the repository at this point in the history
  • Loading branch information
@yihui
yihui committed Jun 30, 2023
1 parent 962b40d commit df9ab6e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions DESCRIPTION
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ Suggests:
testthat (>= 3.0.3),
tibble,
vctrs,
cleanrmd,
withr (>= 2.4.2)
VignetteBuilder: knitr
Config/Needs/website: rstudio/quillt, pkgdown
Expand Down

3 comments on commit df9ab6e

@cderv
Copy link
Collaborator

@cderv cderv commented on df9ab6e Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

And sorry for missing this. I was thinking those test wouldn't run on CRAN, but it seems this is no more true then

rmarkdown/tests/testrmd.R

Lines 1 to 2 in f14fefe

# only run this test on CI platforms
if (.Platform$OS.type == 'unix' && !isTRUE(as.logical(Sys.getenv("CI"))) && rmarkdown::pandoc_available()) {

This is why I did not add to DESCRIPTION in the first place.

Should we adapt to make sure they don't run ?
Or we now consider those tests are integration test running on CRAN ?

@yihui
Copy link
Member Author

@yihui yihui commented on df9ab6e Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries!

I think we got it wrong in !isTRUE(as.logical(Sys.getenv("CI"))) (from fedcdcf#diff-cdec932aeadc70bc5b52b74a6df33508c524690c0c80e30e4a72c9fc2f28ff32): ! should be removed.

@cderv
Copy link
Collaborator

@cderv cderv commented on df9ab6e Jul 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes it seems so ! I'll change that; I did not even see it posting the line above 🤦 😅

Please sign in to comment.