default image from RSCONNECT_IMAGE #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronatkins
commented
Apr 24, 2024
| @@ -126,6 +126,13 @@ createAppManifest <- function(appDir, | |||
| verbose = FALSE, | |||
| quiet = FALSE) { | |||
|
|
|||
| if (is.null(image)) { | |||
There was a problem hiding this comment.
The final image value is inferred "late", but that lets both deployApp() and writeManifest() avoid duplication.
dbkegley
approved these changes
Apr 24, 2024
aronatkins
force-pushed
the
aron-default-image
branch
from
156ba6d to
4d38013
Compare
|
EDIT: RESTART YOUR R SESSION IF YOU HIT THIS: I thought I was seeing issues due to me having built and tested out |
|
Is there a way to not truncate the argument list?
I was hoping to see that we had a default value in there as part of testing. |
|
@aronatkins Do we expect Where I confirmed that the environment variable is used by default as well: Associated Connect logs: With a Associated Connect logs: |
|
|
|
@aronatkins How can I validate that the manifest is aware of the supplied image name, or am I misunderstanding your comment and |
|
@dethmasque - You can look at the manifest to confirm that the image data is present. That's probably sufficient, since you have already checked direct deployment of the manifest using |
|
Ahh I see what I missed in the manifest last week: 
The lack of scroll position jumping (because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1063
@hadley - preference towards R option versus environment variable? The original request was for an environment variable, which feels more "global", especially if we have non-R tooling use the same variable.