Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorado: so long, farewell #1129

Merged
merged 2 commits into from
Jan 21, 2025
Merged

colorado: so long, farewell #1129

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
508a1cc
colorado: so long, farewell
aronatkins Jan 21, 2025
18ed151
test addServer, addConnectServer, and validateServerUrl without using…
aronatkins Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/servers-deprec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# addConnectServer is deprecated

Code
addConnectServer("https://colorado.posit.co/rsc", quiet = TRUE)
addConnectServer("https://connect.posit.it/", quiet = TRUE)
Condition
Warning:
`addConnectServer()` was deprecated in rsconnect 1.0.0.
Expand Down
3 changes: 0 additions & 3 deletions tests/testthat/test-ide.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,12 @@ test_that("validateServerUrl() returns expected", {
expect_false(validateServerUrl("https://posit.cloud")$valid)
expect_false(validateServerUrl("https://shinyapps.io")$valid)
expect_true(validateServerUrl("https://connect.posit.it/")$valid)
expect_true(validateServerUrl("https://colorado.posit.co/rsc")$valid)
})

test_that("validateServerUrl() normalises urls", {
skip_on_cran()

expect_true(validateServerUrl("connect.posit.it/")$valid)
expect_true(validateServerUrl("colorado.posit.co/rsc")$valid)
})

test_that("validateConnectUrl() returns expected return for some known endpoints", {
Expand All @@ -20,7 +18,6 @@ test_that("validateConnectUrl() returns expected return for some known endpoints
expect_false(validateConnectUrl("https://posit.cloud")$valid)
expect_false(validateConnectUrl("https://shinyapps.io")$valid)
expect_true(validateConnectUrl("https://connect.posit.it/")$valid)
expect_true(validateConnectUrl("https://colorado.posit.co/rsc")$valid)
})

test_that("validateConnectUrl() normalises urls", {
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-servers-deprec.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ test_that("addConnectServer is deprecated", {
local_temp_config()

expect_snapshot(
addConnectServer("https://colorado.posit.co/rsc", quiet = TRUE)
addConnectServer("https://connect.posit.it/", quiet = TRUE)
)
})
Loading