Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimum openssl package version in the DESCRIPTION #567

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

atheriel
Copy link
Contributor

@atheriel atheriel commented Mar 3, 2022

The 2.0.0 release contains a change that fixes publishing on FIPS systems, so requiring this minimum version should insulate users from this issue on new installs. See #452 for discussion.

Fixes #452 and #489.

@atheriel atheriel linked an issue Mar 3, 2022 that may be closed by this pull request
Copy link
Contributor

@aronatkins aronatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change be announced in NEWS?

@atheriel
Copy link
Contributor Author

atheriel commented Mar 9, 2022

@aronatkins I'm on the fence about whether it's appropriate. But I'm happy to add an entry if you think it makes sense.

@aronatkins
Copy link
Contributor

I'm leaning towards mentioning this in NEWS just because it avoids a particular class of FIPS issues that a number of folks have hit; it's more about the consequential change in behavior rather than the required version update.

The 2.0.0 release contains a change that fixes publishing on FIPS
systems.

Signed-off-by: Aaron Jacobs <aaron.jacobs@rstudio.com>
@atheriel
Copy link
Contributor Author

Makes sense. Added a NEWS entry.

@atheriel atheriel merged commit 18f15f7 into main Mar 10, 2022
@atheriel atheriel deleted the bump-openssl branch March 10, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggest API keys on FIPS digest errors Implement alternative to OpenSSL RSA keygen
2 participants