Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set content category for outputs and revisions #993

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Conversation

mslynch
Copy link
Contributor

@mslynch mslynch commented Sep 5, 2023

Resolves #988.

@mslynch mslynch requested review from hadley and omar-rs September 5, 2023 21:39
@mslynch mslynch marked this pull request as ready for review September 5, 2023 21:39
Copy link
Contributor

@aronatkins aronatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need any documentation or NEWS update?

@mslynch
Copy link
Contributor Author

mslynch commented Sep 11, 2023

Does this need any documentation or NEWS update?

I think it's probably not notable enough. We use the content category from the bundle manifest already; this just gets that information to us sooner.

R/client-cloud.R Outdated Show resolved Hide resolved
R/client-cloud.R Outdated Show resolved Hide resolved
R/client-cloud.R Outdated Show resolved Hide resolved
@mslynch mslynch merged commit 3e96601 into main Sep 11, 2023
@mslynch mslynch deleted the content-category-cloud branch September 11, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set content_category on static outputs and revisions
4 participants