Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AGU journals template #199

Merged
merged 13 commits into from
Mar 14, 2019
Merged

Adds AGU journals template #199

merged 13 commits into from
Mar 14, 2019

Conversation

eliocamp
Copy link
Contributor

This adds a template for the AGU journals. Tested the skeleton on my machine and it worked. I hope everything else is in order.
Haven't signed up the Contributor Agreement yet because I don't have access to a printer right now, but will do next week :).

@eliocamp
Copy link
Contributor Author

eliocamp commented Dec 3, 2018

I've signed and sent the agreement. :)

@yihui yihui mentioned this pull request Dec 3, 2018
3 tasks
And removes keep_tex by default
@matthewross07
Copy link

Many thanks @eliocamp , I just pulled this branch for an upcoming submission to WRR. Hope to see this request merged soon.

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the files under agu_article/skeleton/trackchanges-0.7.0/ necessary? There are a lot of them.

@eliocamp
Copy link
Contributor Author

They come with the template and is used by the journal to track changes during the submission process, I think.
The template works perfectly without them.

@yihui
Copy link
Member

yihui commented Jan 29, 2019

I see. I'd prefer not to have them in the rticles package. You could add instructions in skeleton.Rmd for those who want to use this feature.

@eliocamp
Copy link
Contributor Author

Ok! I'll be uncomputered until march, I'll do it then!

@yihui
Copy link
Member

yihui commented Jan 29, 2019

No problem. Thank you!

@eliocamp
Copy link
Contributor Author

eliocamp commented Mar 6, 2019

I've removed the trackchanges files and added instructions for using it.

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change the option name options to classoption and merge this PR. Thank you!

inst/rmarkdown/templates/agu_article/skeleton/skeleton.Rmd Outdated Show resolved Hide resolved
R/agu_article.R Outdated Show resolved Hide resolved
@yihui yihui added this to the v0.7 milestone Mar 14, 2019
@yihui yihui merged commit 6c5d802 into rstudio:master Mar 14, 2019
yihui added a commit that referenced this pull request Mar 14, 2019
@eliocamp eliocamp deleted the agu branch March 15, 2019 13:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants