Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Taylor & Francis Journal Template #218

Merged
merged 32 commits into from
Apr 11, 2019
Merged

Adding Taylor & Francis Journal Template #218

merged 32 commits into from
Apr 11, 2019

Conversation

dleutnant
Copy link
Contributor

To contribute a new article template to this package, please make sure you have done the following things (note that journalname_article below is only an example name):

  • Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to jj@rstudio.com.

  • Add the journalname_article() function to R/article.R if the output format is simple enough, otherwise create a separate R/journalname_article.R.

  • Add the Pandoc LaTeX template inst/rmarkdown/templates/journalname_article/resources/template.tex.

  • Add a skeleton article inst/rmarkdown/templates/journalname_article/skeleton/skeleton.Rmd.

  • Add a description of the template inst/rmarkdown/templates/journalname_article/template.yaml.

  • Please include the document class file (*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN. Please keep the number of new files absolutely minimal, and also make examples minimal (e.g., if you need a .bib example, try to only leave one or two bibliography entries in it, and don't include one hundred items in it without using all of them).

  • Update Rd and namespace (could be done by devtools::document()).

  • Update NEWS.

  • Update README with a link to the newly supported journal.

  • Add a test to tests/testit/test-formats.R.

  • Add your name to the list of authors Authors@R in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.

Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base: https://yihui.name/en/2018/02/bite-sized-pull-requests/

Thank you!

@dleutnant
Copy link
Contributor Author

@yihui Are you going to resolve the conflicts or is it me?

@yihui
Copy link
Member

yihui commented Apr 10, 2019

It seems you have resolved conflicts by yourself. Good job! I'll review the PR later.

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My major concern is that the template skeleton.Rmd appears to contain too much raw LaTeX code. I wonder if it is possible to use Markdown syntax in some places, e.g., \emph{foo} could be _foo_, and \texttt{foo} and \verb"foo" could be `foo`, etc. BTW, the correct way to write a pair of single or double quotes is to just write the pair of single or double quotes. The LaTeX syntax `' or ``'' in Markdown won't generate the expected quotes.

R/article.R Outdated Show resolved Hide resolved
R/article.R Outdated Show resolved Hide resolved
inst/rmarkdown/templates/tf_article/skeleton/skeleton.Rmd Outdated Show resolved Hide resolved
yihui and others added 6 commits April 11, 2019 10:26
Co-Authored-By: dleutnant <dleutnant@users.noreply.github.com>
Co-Authored-By: dleutnant <dleutnant@users.noreply.github.com>
Co-Authored-By: dleutnant <dleutnant@users.noreply.github.com>
@dleutnant
Copy link
Contributor Author

I substituted a couple of raw LaTeX codes. I didn't change the way figures and tables are integrated and would like the end user to take care of this. Equations are still enveloped in a LaTeX environment to enable enumeration of equations.

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now (with two minor changes). Thank you very much!

R/article.R Outdated Show resolved Hide resolved
inst/rmarkdown/templates/tf_article/skeleton/skeleton.Rmd Outdated Show resolved Hide resolved
yihui and others added 2 commits April 11, 2019 17:26
Co-Authored-By: dleutnant <dleutnant@users.noreply.github.com>
Co-Authored-By: dleutnant <dleutnant@users.noreply.github.com>
@dleutnant
Copy link
Contributor Author

Thank you!

@yihui yihui merged commit 708b08f into rstudio:master Apr 11, 2019
@dleutnant dleutnant deleted the tf_template branch April 11, 2019 17:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants