Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Journal of Educational Data Mining #251

Merged
merged 20 commits into from
Sep 7, 2021
Merged

Conversation

jooyoungseo
Copy link

@jooyoungseo jooyoungseo commented Oct 16, 2019

Changes

  • Added Journal of Educational Data Mining LaTeX template according to the code of conduct.
  • Added a jedm_article() function in article.R.
  • Added related info to README.md; DESCRIPTION; and NEWS.md.

Building

  • Used Rd2roxygen::rab() function to build rticles package after change has been made.

Testing

I have confirmed that rticles::jedm_article() output format works.

Signed-Form

  • I have signed and submitted the RStudio form to J.J.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jooyoungseo !

For this one too can you verified your PR following the PR template ?
https://github.com/rstudio/rticles/blob/master/.github/PULL_REQUEST_TEMPLATE.md

I don't think there is much missing. Only a new test maybe for this format.

I'll deal with all the conflicts afterward unless you are used to do that - If not don't worry.

@cderv cderv added this to the v0.16 milestone Aug 11, 2020
@cderv

This comment has been minimized.

@yihui

This comment has been minimized.

@cderv

This comment has been minimized.

@cderv cderv removed this from the v0.16 milestone Aug 12, 2020
@cderv cderv removed their assignment Sep 7, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cderv
❌ JooYoung Seo


JooYoung Seo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was long overdue. I made the necessary change for this one.
I believe this is working as expected now.

@cderv cderv changed the title Journal of Educational Data Mining Add Journal of Educational Data Mining Sep 7, 2021
@cderv cderv merged commit 2a16f2d into rstudio:master Sep 7, 2021
@yihui
Copy link
Member

yihui commented Sep 7, 2021

Perfect. Thanks!

cderv added a commit that referenced this pull request Sep 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants