Improvements to OUP format #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Citations not working and strange things happen with a final section, but most other things seem to be working. Template needs further work to do equations and cross-referencing correctly.
Merging back my changes accepted into rstudio version of rticles after pull request.
…box. Modifying template to show how to use knitr::kable for generating tables and how to use place floats at end and number lines using header-includes.
|
I have added to this pull request new changes to make OUP format by default use pandoc-citeproc for reference formatting. I would create a separate pull request for this, but I am not sure how to do that. Also, regarding the check failure above (Travis CI), this appears to be a pandoc download issue that is unrelated to my changes. Am I supposed to do something about this? |
yihui
approved these changes
Aug 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To contribute a new article template to this package, please make sure you have done the following things (note that
journalname_articlebelow is only an example name):[ X] Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to jj@rstudio.com.
[ X] Add the
journalname_article()function toR/article.Rif the output format is simple enough, otherwise create a separateR/journalname_article.R.[X ] Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname_article/resources/template.tex.[ X] Add a skeleton article
inst/rmarkdown/templates/journalname_article/skeleton/skeleton.Rmd.[X ] Add a description of the template
inst/rmarkdown/templates/journalname_article/template.yaml.[X ] Please include the document class file (
*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN. Please keep the number of new files absolutely minimal, and also make examples minimal (e.g., if you need a.bibexample, try to only leave one or two bibliography entries in it, and don't include one hundred items in it without using all of them).[X ] Update Rd and namespace (could be done by
devtools::document()).[X ] Update NEWS.
[X ] Update README with a link to the newly supported journal.
Add a test to
tests/testit/test-formats.R.[X ] Add your name to the list of authors
Authors@Rin DESCRIPTION. You don't need to bump the package version in DESCRIPTION.Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base: https://yihui.name/en/2018/02/bite-sized-pull-requests/
Thank you!