add pihph_article()

[stefanocoretta]

The pull request adds pihph_article() for articles of Papers in Historical Phonology (PiHPh).

✅ R CMD check succeeded.

✅ Pull request check list:

• Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to jj@rstudio.com.

• Add the journalname_article() function to R/article.R if the output format is simple enough, otherwise create a separate R/journalname_article.R.

• Add the Pandoc LaTeX template inst/rmarkdown/templates/journalname/resources/template.tex.

• Add a skeleton article inst/rmarkdown/templates/journalname/skeleton/skeleton.Rmd.

• Add a description of the template inst/rmarkdown/templates/journalname/template.yaml.

• Please include the document class file (*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN. If you are using TinyTeX or TeX Live, you can verify if a package is available on CTAN via tinytex::parse_packages(files = "FILENAME"") (e.g., when FILENAME is plain.bst, it should return "bibtex", which means this file is from a standard CTAN package). Please keep the number of new files absolutely minimal (e.g., do not include PDF output files), and also make examples minimal (e.g., if you need a .bib example, try to only leave one or two bibliography entries in it, and don't include too many items in it without using all of them).

• Update Rd and namespace (could be done by devtools::document()).

• Update NEWS.

• Update README with a link to the newly supported journal. Please add your Github username and the full name of the journal (follow other examples in the list).

• Add a test to tests/testit/test-formats.R by adding a line test_format("journalname"). We try to keep them in alphabetical order.

• Add your name to the list of authors Authors@R in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.

[cderv]

Hi @stefanocoretta,

I planned to review on Monday. Is it closed on purpose ? Do you still suggest we add this format into the package?

[stefanocoretta]

Hi!

Same as with jasa_article(). :)

[cderv]

Thanks for the contribution !

I made a few comments to improve and one thing you must fix : currently adding a bibliography file will fail the rendering. This is because some Pandoc stuff are missing that you need when Pandoc citeproc is used. Your default does not use bibtex or natbib here but Pandoc citeproc.

Thanks!

[stefanocoretta]

Thanks for checking on this! I will work on the other changes in the next days.

[cderv]

From the CI error it seems there is a $end$ or other missing in the template 🤔

[cderv]

I commented on the part that make the CI error

[cderv]

Thanks @stefanocoretta !