add nav-item/nav-link to BS4+ dropdowns

rstudio · May 5, 2021 · 745bee2 · 745bee2
1 parent 7f81a7c
commit 745bee2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 9 deletions.
diff --git a/R/bootstrap.R b/R/bootstrap.R
@@ -1085,7 +1085,18 @@ buildDropdown <- function(divTag, tabset) {
       divTag$title,
       tags$b(class = "caret")
     ),
-    navList
+    navList,
+    .renderHook = function(x) {
+      if (isTRUE(getCurrentThemeVersion() >= 4)) {
+        tagQuery(x)$
+          addClass("nav-item")$
+          find(".dropdown-toggle")$
+          addClass("nav-link")$
+          allTags()
+      } else {
+        x
+      }
+    }
   )
 
   list(

diff --git a/tests/testthat/_snaps/tabPanel.md b/tests/testthat/_snaps/tabPanel.md
@@ -86,8 +86,8 @@
               B
             </a>
           </li>
-          <li class="dropdown">
-            <a href="#" class="dropdown-toggle" data-toggle="dropdown" data-value="Menu">
+          <li class="dropdown nav-item">
+            <a href="#" class="dropdown-toggle nav-link" data-toggle="dropdown" data-value="Menu">
               Menu
               <b class="caret"></b>
             </a>
@@ -121,8 +121,8 @@
               B
             </a>
           </li>
-          <li class="dropdown">
-            <a href="#" class="dropdown-toggle" data-toggle="dropdown" data-value="Menu">
+          <li class="dropdown nav-item">
+            <a href="#" class="dropdown-toggle nav-link" data-toggle="dropdown" data-value="Menu">
               Menu
               <b class="caret"></b>
             </a>
@@ -204,8 +204,8 @@
                 B
               </a>
             </li>
-            <li class="dropdown">
-              <a href="#" class="dropdown-toggle" data-toggle="dropdown" data-value="Menu">
+            <li class="dropdown nav-item">
+              <a href="#" class="dropdown-toggle nav-link" data-toggle="dropdown" data-value="Menu">
                 Menu
                 <b class="caret"></b>
               </a>
@@ -284,8 +284,8 @@
                 B
               </a>
             </li>
-            <li class="dropdown">
-              <a href="#" class="dropdown-toggle" data-toggle="dropdown" data-value="Menu">
+            <li class="dropdown nav-item">
+              <a href="#" class="dropdown-toggle nav-link" data-toggle="dropdown" data-value="Menu">
                 Menu
                 <b class="caret"></b>
               </a>