Fix #1399: Duplicate binding error with insertUI and nested uiOutput #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks OK to me but I'm reluctant to merge it for the upcoming release because there could be unforeseen consequences. |
|
@jcheng5 Can you add a NEW entry? You'll probably want to rebase this branch to get your NEWS.md up to date first. |
jcheng5
force-pushed
the
joe/bugfix/insertui-nested-uioutput
branch
from
9ecb1e8 to
873d0b5
Compare
|
@wch Should be all set now, assuming CI tests pass. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty low-level change. Basically, we find a list of uiOutput elements and bind them one by one. But element 0 is the parent of element 1. Binding element 0 causes element 1 to be removed and replaced with element 1a (which shares an
idwith element 1). But we continue down the list we captured earlier, so element 1 is the next thing we bind. Not only are we binding an element that's been removed from the document, but, we're also re-binding anidthat has just been bound.