Code

Dynamic tabs#1794

Code

Merged

jcheng5 merged 31 commits intomasterrstudio/shiny:masterfrom barbara/tabsrstudio/shiny:barbara/tabsCopy head branch name to clipboardAug 4, 2017

+1,359-197

Commits

Commits on Aug 4, 2017

• changes

  bborgesr

  committed
  20bff18

  Copy full SHA for 20bff18

• add functions to index.r

  bborgesr

  committed
  72a1b3d

  Copy full SHA for 72a1b3d

• finish insertTab

  bborgesr

  committed
  b94efe8

  Copy full SHA for b94efe8

• implement removeTab

  bborgesr

  committed
  fb7b6f6

  Copy full SHA for fb7b6f6

• implement showTab and removeTab

  bborgesr

  committed
  b6b6661

  Copy full SHA for b6b6661

• delete extra brackets

  bborgesr

  committed
  a409562

  Copy full SHA for a409562

• update examples

  bborgesr

  committed
  2813e0b

  Copy full SHA for 2813e0b

• added NEWS and fixed typo

  bborgesr

  committed
  ae7f026

  Copy full SHA for ae7f026

• clean up JS code (1 line only)

  bborgesr

  committed
  0ecdcec

  Copy full SHA for 0ecdcec

• now working for navbarPage and navlistPanel

  bborgesr

  committed
  a4c086f

  Copy full SHA for a4c086f

• document similar things together; add prependTab and appendTab

  bborgesr

  committed
  3adbebc

  Copy full SHA for 3adbebc

• Fixed documentation problems and JS code logic

  bborgesr

  committed
  1ecc9b9

  Copy full SHA for 1ecc9b9

• typo: tag -> tab (makes a big difference!)

  bborgesr

  committed
  8bbf576

  Copy full SHA for 8bbf576

• remove extra line

  bborgesr

  committed
  31bbb38

  Copy full SHA for 31bbb38

• updated docs

  bborgesr

  committed
  e660278

  Copy full SHA for e660278

• refactored code and made insertion of navbarMenus possible

  bborgesr

  committed
  0e7c78b

  Copy full SHA for 0e7c78b

• insertion fully implemented

  bborgesr

  committed
  d57aa33

  Copy full SHA for d57aa33

• more JS code refactoring; improved documentation

  bborgesr

  committed
  10f3320

  Copy full SHA for 10f3320

• implement navigation after hiding/removing selected tab

  bborgesr

  committed
  6f9f3fe

  Copy full SHA for 6f9f3fe

• Properly escape jQuery selector strings

  

  jcheng5

  authored and

  bborgesr

  committed
  48b8923

  Copy full SHA for 48b8923

• Make tab prepend/append just edge cases of insert

  

  jcheng5

  authored and

  bborgesr

  committed
  f1873a0

  Copy full SHA for f1873a0

• Add select=FALSE argument to insert/append/prependTab

  

  jcheng5

  authored and

  bborgesr

  committed
  dde7b14

  Copy full SHA for dde7b14

• htmlDependencies are properly loaded with dynamic tabs

  

  jcheng5

  authored and

  bborgesr

  committed
  91dbb0e

  Copy full SHA for 91dbb0e

• Fix bug where last tab being removed, didn't update tabset input value

  

  jcheng5

  authored and

  bborgesr

  committed
  c090efd

  Copy full SHA for c090efd

• Abandon nearest neighbor tab-showing logic. Just grab the first tab.

  

  jcheng5

  authored and

  bborgesr

  committed
  c1c5873

  Copy full SHA for c1c5873

• for dynamic tabs, send message on session$onFlush (instead of session$onFlushed)

  bborgesr

  committed
  40cfff3

  Copy full SHA for 40cfff3

• added select argument to showTab function

  bborgesr

  committed
  82ac112

  Copy full SHA for 82ac112

• make this PR work for modules

  bborgesr

  committed
  494627c

  Copy full SHA for 494627c

• make hide and remove work well when we want to hide/remove a tab inside a navbarMenu (or the whole menu) and it is selected (before this commit, it wasn't navigating to the first tab like it is sup…

  Show description for ee5da14
  bborgesr

  committed
  ee5da14

  Copy full SHA for ee5da14

• Joe's feedback

  bborgesr

  committed
  ed3ba30

  Copy full SHA for ed3ba30

• do inputId <- session$ns(inputId) in user facing functions for module functionality (rather than overriding the same functions in makeScope)

  bborgesr

  committed
  b02eb11

  Copy full SHA for b02eb11