insertUI() now supports execution of <script> #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… supports execution of <script>
cpsievert
added a commit
to rstudio/shinycoreci-apps
that referenced
this pull request
May 9, 2022
schloerke
reviewed
May 10, 2022
schloerke
approved these changes
May 10, 2022
schloerke
added a commit
to rstudio/shinycoreci
that referenced
this pull request
May 10, 2022
Co-Authored-By: Carson Sievert <cpsievert1@gmail.com>
schloerke
approved these changes
May 10, 2022
wch
changed the title
schloerke
added a commit
to rstudio/shinycoreci
that referenced
this pull request
May 10, 2022
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
schloerke
added a commit
to rstudio/shinycoreci
that referenced
this pull request
May 10, 2022
* main: Add app to test rstudio/shiny#3630 (#96) Display logs in website; Hide logs on first pass; Remove `view_test_diff()` and `view_test_results()` (#97) do not destroy non-pkgdown files Make sure progress bar shows up on GHA update readme ignore artifacts from other branches Add link to test results Merge branch 'main' of github.com:rstudio/shinycoreci Comment warning check as some warning is being cause somewhere outside of our control shinytest2-chromote snapshots review - 6 shinytest2-chromote snapshots review - 5 Change from fixed time sleep to `$wait_for_idle()` where possible (#95) Fix repo location and user running action typo add specific method for 'trigger_tests()' Accept all snaps for fix_snaps(); Fix apps heights and widths. Remove 134 snaps(#94) Generate apps deps (GitHub Actions) shinytest2-chromote snapshots review - 4 Fix a handful of apps to create consistent screenshots (#93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1545