Reduce stack trace length #4186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
commented
Feb 4, 2025
Comment on lines
+97
to
+100
| 1 69 <Anonymous> | ||
| 2 68 signalCondition | ||
| 3 67 signal_abort | ||
| 4 66 rlang::abort |
There was a problem hiding this comment.
The goal is to get rid of these, but my approach doesn't work currently. Let me know if you have an idea on how to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the stack trace isn't truncated well if a package uses cli or rlang to throw errors. This is common in many tidyverse packages for example.
This PR adds some calls to allow truncating the top of the stack trace a bit more.
Opening the PR from discussion, because it doesn't really work since I can't seem to get rid of the "" call..