Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #129: Trigger shown/hidden event for Shiny outputs in the sidebar #194

Merged
merged 4 commits into from
Mar 6, 2017
Merged

Closes #129: Trigger shown/hidden event for Shiny outputs in the sidebar #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b72cbd
Closes #129: Trigger shown/hidden event for Shiny outputs in the sidebar
bborgesr Mar 3, 2017
7a5a013
do not require menuItems to have a tabName
bborgesr Mar 3, 2017
76fafc4
add NEWS item
bborgesr Mar 6, 2017
1d67c51
Winston's feedback
bborgesr Mar 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
shinydashboard 0.5.3.9000
=========================

* Fixed [#129](https://github.com/rstudio/shinydashboard/issues/129): Trigger shown/hidden event for Shiny outputs in the sidebar. ([#194](https://github.com/rstudio/shinydashboard/pull/194))

* Fixed [#73](https://github.com/rstudio/shinydashboard/issues/73): add `collapsed` argument to `dashboardSidebar()`, which allows it to start off collapsed. ([#186](https://github.com/rstudio/shinydashboard/pull/186))

* Fixed [#62](https://github.com/rstudio/shinydashboard/issues/62): make images resize when the sidebar collapses/expands. [#185](https://github.com/rstudio/shinydashboard/pull/185)
Expand Down
4 changes: 4 additions & 0 deletions inst/shinydashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ $(function() {
$(window).trigger("resize");
});

$(document).on("click", ".treeview > a", function() {
$(this).next(".treeview-menu").trigger("shown");
});

// menuOutputBinding
// ------------------------------------------------------------------
// Based on Shiny.htmlOutputBinding, but instead of putting the result in a
Expand Down