Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in glue_sys_reqs() #142

Closed
csgillespie opened this issue Sep 19, 2022 · 1 comment
Closed

Bug in glue_sys_reqs() #142

csgillespie opened this issue Sep 19, 2022 · 1 comment

Comments

@csgillespie
Copy link
Contributor

I think the following is incorrect,

vetiver:::glue_sys_reqs("shiny")
#RUN apt-get update -qq && apt-get install -y --no-install-recommends \
 # make

as shiny should depend on zlibg as well.

I think the error is this line:

sys_reqs <- sort(unique(map_chr(sys_reqs, 1L)))

Happy to submit a PR.

@juliasilge
Copy link
Member

Yeah, I think you're right that something has gone wrong there. The line before looks OK (this is for shiny):

> map(sys_reqs$requirements, pluck, "requirements", "packages")
[[1]]
[[1]][[1]]
[1] "make"


[[2]]
[[2]][[1]]
[1] "make"


[[3]]
[[3]][[1]]
[1] "make"

[[3]][[2]]
[1] "zlib1g-dev"

A PR would be fantastic, if you are able! Could you add a test for this function that is skipped on CRAN, for a few real packages?

csgillespie added a commit to csgillespie/vetiver-r that referenced this issue Sep 19, 2022
csgillespie added a commit to csgillespie/vetiver-r that referenced this issue Sep 20, 2022
@csgillespie csgillespie mentioned this issue Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants