Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for
luz
#187Support for
luz
#187Changes from all commits
ef34f20
21d188c
b8460b9
0e8b5fa
e0ae2c1
217185d
c6562b6
57ffbba
8d21a05
8679440
4c75d50
abe11d1
9f29d68
ed2d042
66344c3
d625d37
66ce9ed
9276fa9
8b84b36
6b7c735
43960f0
ff83bd6
c0a2956
40e637e
63d9ffb
94dd35a
eedce33
adf8cb0
31d484e
28206dc
1f2fd90
c11949a
6f7b30a
7f367c9
6799654
7ef9d5d
abcba74
a35d8ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me a little more about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we return the closure directly, without evaluating
vetiver_model
, it will not be in the in the function env until the first closure call - but at this pointvetiver_model
could potentially have been garbage collected. This might not be the case for vetiver though, just feels like a good practice toforce
before returning the closure.I'm trying to avoid something like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the details!
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.