Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS 2 Jazzy対応 #80

Merged
merged 23 commits into from
Nov 25, 2024
Merged

ROS 2 Jazzy対応 #80

merged 23 commits into from
Nov 25, 2024

Conversation

KuraZuzu
Copy link

@KuraZuzu KuraZuzu commented Nov 21, 2024

What does this implement/fix?

ROS 2 Jazzyに対応します。

Does this close any currently open issues?

しません

How has this been tested?

環境

  • Ubuntu 24.04 Desktop
    • 6.8.0-49-generic
  • ROS 2 Jazzy Desktop
  • Gazebo Harmonic v8.6.0

実施内容

READMEの手順に従いテストしました。LiDARを使用した機能はurgldsrplidarの3種類で実行しました。

READMEの記述にあるサンプルプログラムには、以下のパッケージが必要です。

リリースはされていませんが、feature/support-jazzyのブランチでテストしています。

$ git clone -b feature/support-jazzy https://github.com/rt-net/raspimouse_ros2_examples.git
$ git clone -b feature/support-jazzy https://github.com/rt-net/raspimouse_slam_navigation_ros2.git

Any other comments?

raspimouse_ros2_examplesraspimouse_slam_navigation_ros2がサンプルプログラムに必要である補足をREADMEに追記しています。

Checklists

@KuraZuzu KuraZuzu added the Type: Feature New Feature label Nov 21, 2024
@KuraZuzu KuraZuzu self-assigned this Nov 21, 2024
@YusukeKato
Copy link
Contributor

READMEに記載されている内容の動作確認できました!

Copy link
Contributor

@YusukeKato YusukeKato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントの確認をお願いいたします。

README.en.md Outdated

## Installation

Download this ROS 2 package.

```sh
cd ~/ros2_ws/src
git clone -b ros2 https://github.com/rt-net/raspimouse_sim.git
$ cd ~/ros2_ws/src
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コピペしやすいように、コマンドの先頭の$マークはなくて大丈夫です。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

各所での$記号を削除しました。

README.en.md Outdated
cd ~/ros2_ws/src
git clone -b ros2 https://github.com/rt-net/raspimouse_sim.git
$ cd ~/ros2_ws/src
$ git clone -b ros2 https://github.com/rt-net/raspimouse_sim.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ブランチはros2よりjazzyのほうがよさそうなので修正をお願いしたいです(ros2ブランチが次のディストリビューションへ以降した際に修正が必要になってしまうので)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。

@KuraZuzu
Copy link
Author

ご指摘の点を修正しました。

@YusukeKato
Copy link
Contributor

修正ありがとうございます。
LGTMです!

@YusukeKato YusukeKato merged commit e3c8283 into ros2 Nov 25, 2024
1 check passed
@YusukeKato YusukeKato deleted the feature/support-jazzy branch November 25, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants