Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: theme initialization issue on Windows using Powershell/Command prompt #89

Closed
wants to merge 1 commit into from

Conversation

mi5t4n
Copy link
Member

@mi5t4n mi5t4n commented Dec 12, 2023

Description

This PR fixes theme initialization issue on Windows using Powershell/Command prompt while running npm run init command. Explicitly uses node to run the ./bin/init.js tool.

How to Test?

  1. On Windows platform using either Powershell or Command prompt.
  2. Run git checkout master to checkout to master branch.
  3. Run npm install to run JS dependencies.
  4. Run npm run init to initialize theme, but the command should throw error as in the screenshot.
  5. Run git checkout fix/66 to switch branch.
  6. Run npm run init to initialize theme, now the command should work properly as intended.

Screenshots

Before:

2023-12-12_12-29

After:

2023-12-12_12-26

To-do

Fixes/Covers issue

Fixes #66

@mi5t4n mi5t4n self-assigned this Dec 12, 2023
@mi5t4n mi5t4n closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue on Windows when I run npm run init
1 participant