-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Purge for AMP URL when a Post or Page is Published. #353
base: develop
Are you sure you want to change the base?
Conversation
</span> | ||
</legend> | ||
<label for="purge_amp_urls"> | ||
<input type="checkbox" value="1" id="purge_amp_urls" name="purge_amp_urls" <?php checked( $nginx_helper_settings['purge_amp_urls'], 1 ); ?> /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this option enabled by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SH4LIN I have enabled it in accordance with the default behaviour since, by default, all other options—aside from comments—are enabled when purge is enabled.
admin/class-fastcgi-purger.php
Outdated
* @param string $url_base The base URL to purge. | ||
*/ | ||
private function purge_amp_version( $url_base ) { | ||
$amp_url = $url_base . '/amp/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use sprintf()
admin/class-fastcgi-purger.php
Outdated
|
||
$this->log('- Purging AMP URL | ' . $amp_url); | ||
|
||
if ($this->nginx_helper_admin->options['purge_method'] === 'unlink_files') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Yoda condition and add spaces at start and end of the brackets
Description
The aim of this PR is to add support for purging AMP URL's.
Type
Reference Issue
Testing
The code has been tested locally and is working as expected.