Update node version and NPM packages #78
Conversation
Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
Because the current next-offline package has not been updated since 2 years. We will be implementing it later using probably next-pwa package. Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
| import Link from 'next/link'; | ||
| import client from '../src/apollo/ApolloClient'; | ||
| import AddToCartButton from '../src/components/cart/AddToCartButton'; | ||
| import Hero from '../src/components/home/Hero'; | ||
| import Image from '../src/components/Image'; | ||
| import Layout from '../src/components/layouts/Layout'; |
There was a problem hiding this comment.
@Souptik2001 Let's segregate these with comments, Internal dependencies and external dependencies resp. Lets do that where applicable.
There was a problem hiding this comment.
@imranhsayed Just to be once confirmed you meant like this right? -
// External.
import Link from 'next/link';
// Internal.
import client from '../src/apollo/ApolloClient';
import AddToCartButton from '../src/components/cart/AddToCartButton';
import Hero from '../src/components/home/Hero';
import Image from '../src/components/Image';
import Layout from '../src/components/layouts/Layout';There was a problem hiding this comment.
Exactly @Souptik2001 Looks more organised.
There was a problem hiding this comment.
@Souptik2001 When we assign the issue back for review, it's the reviewer who will mark the comments resolved after checking.
There was a problem hiding this comment.
@Souptik2001 Let's rename the comments to Internal Dependencies and External Dependencies respectively.
| ] = useMutation(LOGIN_USER, { client }) | ||
| const [login, { data: data, loading: loading, error: error }] = useMutation(LOGIN_USER, { | ||
| client | ||
| }); |
There was a problem hiding this comment.
@Souptik2001 Let's break it into multiple lines to make it more readable
There was a problem hiding this comment.
@imranhsayed As per the current prettier configuration, as this line doesn't exceed a threshold line length limit, that's why it is showing error if we are breaking this line.
So, should we change that configuration, because otherwise there will be linting error.
There was a problem hiding this comment.
Yes please. let's update the configuration to make it look more readable @Souptik2001
Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
to distinguish between external and internal imports. Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
| {totalPrice ? ( | ||
| <span className="wp-cart-price mr-2">${totalPrice.toFixed(2)}</span> | ||
| ) : ( | ||
| '' |
There was a problem hiding this comment.
@Souptik2001 Let's update all the '' empty quotes to null
|
@Souptik2001 @imranhsayed Just FYI, I am putting this through in #80. |
Issue - #71
This PR -
next-offline) has not been updated since last 2 years. We will be integrating it later with maybenext-pwapackage. Reference issue.