Fix AXFR-style IXFR with multiple messages. #1151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inbound xfr code is conflating the expected rdtype in responses with the incremental/replacement response style. This causes a problem when an AXFR-style IXFR response spans multiple messages, as resetting the style to AXFR (replacement) also changed the expected type in the question section of future responses to AXFR.
This change separates out the style from the expected rdtype.
This should fix #1150.