Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.1.0] New Create Filters Modal Shows on All Open Pages #140

Closed
rthaut opened this issue May 19, 2020 · 0 comments
Closed

[v6.1.0] New Create Filters Modal Shows on All Open Pages #140

rthaut opened this issue May 19, 2020 · 0 comments
Assignees
@rthaut
Labels
bug
Milestone
v6.1.1

Comments

@rthaut
Copy link
Owner

rthaut commented May 19, 2020

If multiple tabs/windows are open on www.deviantart.com, using the "Create Filters from this Deviation" context menu option on any tab/window shows the modal on all of the open tabs/windows.

This is caused by using the SendMessageToAllTabs helper function in the onClicked event handler for that menu item.

It appears to be a very simple fix: just change this logic to instead use browser.tabs.sendMessage() and pass the tab.id that is sent to the event handler.
@rthaut rthaut added the bug label May 19, 2020
@rthaut rthaut added this to the v6.1.1 milestone May 19, 2020
rthaut added a commit that referenced this issue May 21, 2020
@rthaut
fix: only show create filter modal on requesting tab; fixes #140
aa22778
@rthaut rthaut self-assigned this May 21, 2020
@rthaut rthaut mentioned this issue May 22, 2020
Merged
@rthaut rthaut closed this as completed in 6b85451 May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rthaut rthaut

Labels
bug
Projects
None yet
Milestone
v6.1.1
Development

No branches or pull requests
1 participant
@rthaut