Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-305: Update documentation #194

Merged
merged 7 commits into from
Mar 8, 2024
Merged

Conversation

Alxe
Copy link
Member

@Alxe Alxe commented Mar 8, 2024

Remove references to Connector for Python, update Platform Notes, update License.

@Alxe Alxe requested review from elainerti and lloadholt March 8, 2024 09:20
@rkorte
Copy link
Collaborator

rkorte commented Mar 8, 2024

Please update the (c) years here: https://github.com/rticommunity/rticonnextdds-connector-js/blob/release/connector/1.3.0/docs/copyright_license.rst

  • change this first line: © 2024 Real-Time Innovations, Inc. |br| All rights reserved. |br| Printed in U.S.A. First printing. |br| March 2024. |br|
  • and later below: change © 2022 to © 2024

@rkorte rkorte self-requested a review March 8, 2024 15:39
@elainerti
Copy link
Collaborator

In the json-parser copyright file:
https://github.com/rticommunity/rticonnextdds-connector-js/blob/release/connector/1.3.0/docs/copyright_license.rst

I think need to do something similar to what we do in the core third party file:
https://community.rti.com/static/documentation/connext-dds/7.3.0/doc/manuals/connext_dds_professional/release_notes_3rdparty/connector.html#json-parser

2 issues

  1. we need to add the version. Version 1.1.0
  2. I think the license header is not matching. Likely the one in core is the correct one:
    Copyright (C) 2012-2021 the json-parser authors All rights reserved.

README.md Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
docs/copyright_license.rst Outdated Show resolved Hide resolved
docs/intro.rst Outdated Show resolved Hide resolved
alexcamposruiz and others added 2 commits March 8, 2024 08:32
Co-authored-by: lloadholt <117761400+lloadholt@users.noreply.github.com>
@alexcamposruiz alexcamposruiz self-requested a review March 8, 2024 16:38
@lloadholt lloadholt closed this Mar 8, 2024
@lloadholt lloadholt reopened this Mar 8, 2024
@lloadholt
Copy link
Collaborator

@alexcamposruiz Update year 2022 to 2024 in conf.py.

@lloadholt
Copy link
Collaborator

@alexcamposruiz Could you plz create a new PR in the rticonnextdds-connector repo to address this comment?

All rights reserved. |br|
Printed in U.S.A. First printing. |br|
February 2022. |br|
May 2024. |br|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
May 2024. |br|
March 2024. |br|

@alexcamposruiz alexcamposruiz merged commit 59a65f1 into develop Mar 8, 2024
6 checks passed
@alexcamposruiz alexcamposruiz deleted the feature/CON-305-additions branch March 8, 2024 19:52
alexcamposruiz pushed a commit that referenced this pull request Mar 8, 2024
alvinkrebs added a commit that referenced this pull request Jun 12, 2024
* COMMUNITY-78: update submodule

* COMMUNITY-86 | Backport COMMUNITY-79 and COMMUNITY-80 to release/connector/1.3.0 (#191)

* COMMUNITY-86: backport COMMUNITY-79 back to release/connector/1.3.0

* COMMUNITY-86: backport COMMUNITY-80 back to release/connector/1.3.0

* COMMUNITY-86: update submodule

* CON-305: Update Platform Notes (#192)

* Apply suggestions from code review

* CON-305: Update documentation (#194)

* Fix license pdf (#197)

* Use the current lts instead of the latest one (#196)

* Use current lts instead of the latest one fixes #195

* 20 is equal to lts-iron

* Update submodule commit

* Update submodule commit

* CON-311: Add warning to documentation (#199)

* CON-311: Add warning to documentation

* CON-311: Apply feedback

* CON-311: Add GH Issue link

* Update docs/release_notes.rst

Co-authored-by: lloadholt <117761400+lloadholt@users.noreply.github.com>

---------

Co-authored-by: lloadholt <117761400+lloadholt@users.noreply.github.com>

* DOC-489: Correct headings in Previous Releases section (#200)

* DOC-489: Correct headings in Previous Releases section

* DOC-489: More corrections

* DOC-489: Increase index depth

* DOC-489: Heading corrections

* Update release_notes.rst (#201)

* IRONSIDE-1156 -- PR comment, must include lts in config file ...

* Correct release_notes.rst

Moved 1.0.0 text to heading "Version 1.0.0"

* Update release_notes.rst

---------

Co-authored-by: ManuelJNunez <manueljesusnunezruiz@gmail.com>
Co-authored-by: Alejandro <alejnp@rti.com>
Co-authored-by: Alex Campos <alejandro@rti.com>
Co-authored-by: lloadholt <117761400+lloadholt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants