Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for windows #30

Closed
wants to merge 3 commits into from
Closed

Conversation

stereobooster
Copy link

Sending PR to keep you update on my progress. Work not done yet.

Current result of runing tests https://gist.github.com/3845607

Windows related issues #17, #18, #9

@stereobooster
Copy link
Author

testing win32-process (by @djberg96) to support fork, no luck yet

@djberg96
Copy link

djberg96 commented Oct 7, 2012

The fork implementation was removed in the latest implemenation of win32-process. It was always experimental. Between the addition of Process.spawn in 1.9 and thread programming in general, I just didn't feel it was worth keeping or maintaining. If anything, it should be packaged as a separate lib.

@stereobooster
Copy link
Author

ruby -v 
ruby 1.9.3p194 (2012-04-20) [i386-mingw32]
 56) Failure:
test_spawn_redirect_stderr_and_stdout_to_same_fd(NativeSpawnTest) [d:/projects/posix-pawn/test/test_spawn.rb:180]:
<"hello world\n"> expected but was
<"d:/projects/posix-spawn/test/test_spawn.rb:399: warning: cannot close fd before spawn\nhello world \n">.

@luislavena Aren't those warning: cannot close fd before spawn fixed? http://bugs.ruby-lang.org/issues/4798

@luislavena
Copy link

@stereobooster sorry, just catching up. Not sure if this project errors are fixed by Ruby bug you linked. Is not clear to me how they relate.

Can you try running this project over latest Ruby and see how it goes?

@stereobooster
Copy link
Author

Isn't ruby 1.9.3p194 (2012-04-20) [i386-mingw32] the latest Ruby (on windows)? Or you mean complie latest ruby from trunk?

P.S. There are only 3 those errors, but 95 failed tests. So it's not biggest problem.

@rtomayko
Copy link
Owner

rtomayko commented Apr 3, 2015

Closing as stale. Please reopen if we still want to pursue this PR.

@rtomayko rtomayko closed this Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants