-
Notifications
You must be signed in to change notification settings - Fork 448
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixed error message for clang on MacOSX
The error msg was: _Pragma ("clang diagnostic ignored \"-Wnoexcept-type\"") The version scheme for clang on MacOSX is different then for the other operating systems. The version prior clang 9 on mac did not support this pragma. So we disable it. thx to @gabyx
- Loading branch information
Showing
2 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -278,12 +278,11 @@ namespace rttr | |
# define RTTR_BEGIN_DISABLE_CONDITIONAL_EXPR_WARNING | ||
# define RTTR_END_DISABLE_CONDITIONAL_EXPR_WARNING | ||
|
||
#if RTTR_COMP_VER >= 500 | ||
|
||
#if (RTTR_COMP_VER >= 500 && RTTR_PLATFORM != RTTR_PLATFORM_APPLE) || | ||
(RTTR_COMP_VER >= 900 && RTTR_PLATFORM == RTTR_PLATFORM_APPLE) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
gabyx
Contributor
|
||
# define RTTR_BEGIN_DISABLE_EXCEPT_TYPE_WARNING _Pragma ("clang diagnostic push") \ | ||
_Pragma ("clang diagnostic ignored \"-Wnoexcept-type\"") | ||
# define RTTR_END_DISABLE_EXCEPT_TYPE_WARNING _Pragma ("clang diagnostic pop") | ||
|
||
#else | ||
# define RTTR_BEGIN_DISABLE_EXCEPT_TYPE_WARNING | ||
# define RTTR_END_DISABLE_EXCEPT_TYPE_WARNING | ||
|
@@ -303,7 +302,7 @@ namespace rttr | |
# define RTTR_END_DISABLE_EXCEPT_TYPE_WARNING | ||
|
||
#else | ||
# pragma message("WARNING: ukown compiler, don't know how to disable deprecated warnings") | ||
# pragma message("WARNING: unknown compiler, don't know how to disable deprecated warnings") | ||
#endif | ||
|
||
} // end namespace rttr | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are you sure, this fixes that correctly?
because I used the following
maybe you merge my branch to see.
Because
RTTR_PLATFORM_APPLE
is not meaning we are using AppleClang ;)it just says we are on apple, (we can use gcc... or whatever)