Update GitHub workflow #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
force-pushed
the
github-workflow
branch
from
8976475
to
bb128a8
Compare
|
The hidapi/libusb post-build cleanup does not seem to work as expected. I will remove it for now. |
uklotzde
force-pushed
the
github-workflow
branch
from
7c3d3bf
to
bb128a8
Compare
|
The TODO is fixed now. The cleanup after the build step was missing. |
|
Thx for improving our CI! Unfortunately I am a bit too busy the next few days, so I will not be able to review until next week probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the individual commits for details.
@ruabmbua You probably forgot to update the workflow triggers fromObsoletemastertomain. See the first commit.