address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>
ruanyl · Mar 8, 2024 · 4804cb3 · 4804cb3
1 parent 023fa9b
commit 4804cb3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/core/utils/constants.ts b/src/core/utils/constants.ts
@@ -9,4 +9,8 @@ export const WORKSPACE_PATH_PREFIX = '/w';
 
 export const PUBLIC_WORKSPACE_ID = 'public';
 
+/**
+ * deafult workspace is a virtual workspace,
+ * saved objects without any workspaces are consider belongs to default workspace
+ */
 export const DEFAULT_WORKSPACE_ID = 'default';
diff --git a/...d_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx b/...d_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx
@@ -40,6 +40,7 @@ import {
 
 import React from 'react';
 import { Query } from '@elastic/eui';
+import { waitFor } from '@testing-library/dom';
 import { ShallowWrapper } from 'enzyme';
 import { shallowWithI18nProvider } from 'test_utils/enzyme_helpers';
 import {
@@ -65,7 +66,6 @@ import { SavedObjectWithMetadata } from '../../types';
 import { WorkspaceObject } from 'opensearch-dashboards/public';
 import { DEFAULT_WORKSPACE_ID } from '../../../../../core/public';
 import { TableProps } from './components/table';
-import { waitFor } from '@testing-library/dom';
 
 const allowedTypes = ['index-pattern', 'visualization', 'dashboard', 'search'];
 

diff --git a/src/plugins/workspace/public/plugin.test.ts b/src/plugins/workspace/public/plugin.test.ts
@@ -9,7 +9,7 @@ import { applicationServiceMock, chromeServiceMock, coreMock } from '../../../co
 import { WorkspacePlugin } from './plugin';
 import { WORKSPACE_FATAL_ERROR_APP_ID, WORKSPACE_OVERVIEW_APP_ID } from '../common/constants';
 import { Observable, Subscriber } from 'rxjs';
-import { savedObjectsManagementPluginMock } from 'src/plugins/saved_objects_management/public/mocks';
+import { savedObjectsManagementPluginMock } from '../../saved_objects_management/public/mocks';
 
 describe('Workspace plugin', () => {
   beforeEach(() => {