Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: authInfo destructure (#7) #296

Merged

Conversation

SuZhou-Joe
Copy link
Collaborator

  • fix: authInfo destructure

  • fix: unit test error


Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* fix: authInfo destructure

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.91%. Comparing base (0cef35d) to head (a65dae6).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           workspace-pr-integr     #296      +/-   ##
=======================================================
- Coverage                66.92%   66.91%   -0.01%     
=======================================================
  Files                     2598     2598              
  Lines                    49149    49149              
  Branches                  8890     8890              
=======================================================
- Hits                     32891    32889       -2     
- Misses                   14090    14091       +1     
- Partials                  2168     2169       +1     
Flag Coverage Δ
_2 55.38% <ø> (ø)
_3 43.32% <ø> (-0.01%) ⬇️
_4 35.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit f7009e6 into ruanyl:workspace-pr-integr Mar 15, 2024
44 of 46 checks passed
SuZhou-Joe added a commit that referenced this pull request Mar 18, 2024
* fix: authInfo destructure



* fix: unit test error



---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants