Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace overview page #320

Closed

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Apr 8, 2024

Description

image

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 32.80%. Comparing base (0f34d69) to head (1bc3745).
Report is 9 commits behind head on workspace-pr-integr.

Files Patch % Lines
src/core/public/chrome/chrome_service.tsx 0.00% 6 Missing ⚠️
src/plugins/workspace/public/plugin.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           workspace-pr-integr     #320      +/-   ##
=======================================================
- Coverage                35.17%   32.80%   -2.37%     
=======================================================
  Files                     1885     2241     +356     
  Lines                    36421    45433    +9012     
  Branches                  6672     7127     +455     
=======================================================
+ Hits                     12810    14904    +2094     
- Misses                   22761    29805    +7044     
+ Partials                   850      724     -126     
Flag Coverage Δ
_1 32.80% <16.66%> (?)
_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am force-pushed the workspace_overview branch 2 times, most recently from acb95e6 to ed42c8a Compare April 8, 2024 09:37
@Hailong-am Hailong-am force-pushed the workspace_overview branch 2 times, most recently from 8846c19 to d4605c5 Compare April 19, 2024 16:44
Signed-off-by: Hailong Cui <ihailong@amazon.com>

address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

address ux review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

Add workspace overview to breadCrumb

Signed-off-by: Hailong Cui <ihailong@amazon.com>

getting start modal & settings tab

Signed-off-by: Hailong Cui <ihailong@amazon.com>

home breadcrumb

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix rebase issue

Signed-off-by: Hailong Cui <ihailong@amazon.com>

tmp enable management

Signed-off-by: Hailong Cui <ihailong@amazon.com>

add workspace overview collapsed into localStorage

Signed-off-by: Hailong Cui <ihailong@amazon.com>

getting start modal

Signed-off-by: Hailong Cui <ihailong@amazon.com>

page layout

Signed-off-by: Hailong Cui <ihailong@amazon.com>

Add test cases

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix breadcrumb

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants