Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/backport 6459 to workspace pr integr #332

Merged

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Apr 17, 2024

Description

  1. fix(workspace): apps are missing when updating a workspace
  2. refactor workspace list page to use workspaceConfigurableApps

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ruanyl added 3 commits April 18, 2024 11:17
This is caused by opensearch-project#6234 which marked apps as inaccessible when the apps
are not configured into the current workspace. However, inaccessible
apps can not be configured into a workspace.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl force-pushed the backport/backport-6459-to-workspace-pr-integr branch from 47065e7 to c498cba Compare April 18, 2024 04:25
@ruanyl ruanyl merged commit 9d6094f into workspace-pr-integr Apr 19, 2024
43 checks passed
@github-actions github-actions bot deleted the backport/backport-6459-to-workspace-pr-integr branch April 19, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant