Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][Workspace] Add Workspace filter to saved objects management page (#6… #334

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

Hailong-am
Copy link
Collaborator

…458)

fix failed test case

move workspace column to its own folder

  • default workspace

fix test case

add test case

remove hide import

  • address review comments

  • replace default workspace with public workspace (replace default workspace with public workspace #322)

  • Add workspace filter

  • revert query params change

  • udpate test case name to more clear

  • support public workspace

  • Add changelog

  • update fetchExportByTypeAndSearch parameter

  • remove virtrual public workspace

  • update comments

  • fix public workspace query when permission is not enabled

  • home dashboards/listing page only show public workspace data

  • Add more test case


Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Hailong-am and others added 2 commits April 19, 2024 18:34
…ensearch-project#6458)

* Add workspace filter into saved objects page (opensearch-project#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix failed test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

move workspace column to its own folder

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* default workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

add test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

remove hide import

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* replace default workspace with public workspace (opensearch-project#322)

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add workspace filter

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* revert query params change

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* support public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add changelog

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add more test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am merged commit 0a5604e into ruanyl:workspace-pr-integr Apr 22, 2024
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant