Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - set limit to 100 again #2117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Hotfix - set limit to 100 again #2117

wants to merge 2 commits into from

Conversation

erikaas24
Copy link
Contributor

Changes

  • Set limit to 100
  • Make table top-bar sticky
  • Make the table colors alternate
  • Change text color in table to reflect theme

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
indok-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:05pm

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (07dd5c4) to head (2801e19).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2117   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files         100      100           
  Lines        3580     3580           
=======================================
  Hits         2982     2982           
  Misses        598      598           
Flag Coverage Δ
apitests 83.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 7, 2024

Indøk Web    Run #3353

Run Properties:  status check failed Failed #3353  •  git commit b13cb442ee ℹ️: Merge 2801e195a683092ab79cb1829f4b1ae44764378a into 07dd5c4eaab8678d7af4ea8fd55e...
Project Indøk Web
Branch Review Pages-order-info
Run status status check failed Failed #3353
Run duration 01m 25s
Commit git commit b13cb442ee ℹ️: Merge 2801e195a683092ab79cb1829f4b1ae44764378a into 07dd5c4eaab8678d7af4ea8fd55e...
Committer Erik Aas
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/landing/feide.cy.ts • 1 failed test • E2E

View Output

Test Artifacts
SSO login > should prompt registration when not registered Test Replay Screenshots

@MagnusHafstad
Copy link
Contributor

MagnusHafstad commented Nov 26, 2024

In the future if you hotfix something the PR should say:
What was broken
Why it needed to be fixed
Why does this PR fix it

Also if a commit fixes something in production it should not have new features. It makes it harder to merge quickly as the reviewer needs to look through the whole request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants